HYDRA-1175 : Use LightsManagement scene index instead of removing the… #249
Conversation
… light prims for maya native data, update the unit tests
| const std::set<PXR_NS::SdfPath>& activeLightsPrims) | ||
| { | ||
| if (_disabledLightsPrims != activeLightsPrims) { | ||
| _disabledLightsPrims = activeLightsPrims; |
There was a problem hiding this comment.
Bit confused on the nomenclature here, shouldn't the parameter name be disabledLightPrims and not activeLightsPrims? The prims passed here are the non-active ones, correct?
There was a problem hiding this comment.
Good catch, I started by naming this function SetActiveLightsPrims, this is a leftover from that naming, I'll fix it.
| @@ -151,7 +196,7 @@ createNode aiImagerDenoiserOidn -s -n "defaultArnoldDenoiser"; | |||
| rename -uid "F3377A5A-4A07-7C62-07C5-D68E104F2CB2"; | |||
| createNode file -n "file1"; | |||
| rename -uid "6E5F111E-40E1-79BC-D1C7-2588F65A88E1"; | |||
| setAttr ".ftn" -type "string" "./UVChecker.png"; | |||
| setAttr ".ftn" -type "string" "D:/GIT/maya-hydra-opensource/test/testSamples/testMayaLightingModes/UVChecker.png"; | |||
There was a problem hiding this comment.
Not sure if it's going to cause issues, but can this path be made relative?
| @@ -33,8 +33,11 @@ def IMAGE_DIFF_FAIL_PERCENT(self): | |||
| # Only the "all lights with shadows" check fails, and shadows with point light only is skipped. | |||
| if platform.system() == "Darwin": | |||
| return 3 | |||
| if mayaUtils.mayaMajorVersion() == 2025: | |||
| return 2 #There are more pixels different in maya 2025 for this test | |||
There was a problem hiding this comment.
Just making sure, but I'm guessing the difference is small enough that it doesn't warrant separate reference images?
There was a problem hiding this comment.
No I had an error of about 2440 pixels (~1.5%).
I did an image compare to see the differences and it was sparse pixels here and there, nothing important and only in maya 2025 under Windows and Linux...
|
Few questions, overall looking good, thanks! |
| @@ -71,9 +71,13 @@ class LightsManagementSceneIndex : public PXR_NS::HdSingleInputFilteringSceneInd | |||
| FVP_API | |||
| LightingMode GetLightingMode()const {return _lightingMode;} | |||
|
|
|||
| protected: | |||
| FVP_API | |||
| void SetDisabledLightsPrims(const std::set<PXR_NS::SdfPath>& activeLightsPrims); | |||
There was a problem hiding this comment.
The parameter should also be renamed here
… light prims for maya native data, update the unit tests