-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with Es_delayeds execution of commands #41
Comments
I'm unable to reproduce the issue with the following test code:
Output:
Manually entering it in the server console:
Please try to give a minimalistic example that reproduces the issue. |
Yes, naturally you wont have any issues or bugs testing our these commands as they are already built-in EventScripts commands.
Under normal circumstances prior to the implemented change, or when using the change above, then this will cause the player to run at a 250% speed. |
I have gotten a few reports of cases from WCS users where certain parts of the skills would not work.
These skills were working for me when I tested them. Today I updated my Emulator to the most recent version and I am now experiencing the same issue as the other users.
It turns out, that using es_delayed followed by a command will cause that command to not be executed.
But if you do es_delayed followed by es and then followed by the command, then the command will be executed.
Although this doesn't seem to apply to certain built-in eventscripts commands, this seems to break a lot of custom commands outside of eventscripts.
This is of course not ideal, but it apparently has been like this for a long time. But it hasn't been as noticeable because in the past it has been this way but only when executing the commands through the server console.
But with the change you made the 10th of April this year, it changed it around so the problem wasn't occurring in the server console anymore, however, it instead started occurring in every script. Meaning that all scripts using es_delayed would need to be changed to es_delayed es instead in order for them to be executed.
The change I'm referring to is one:
3f326be
I have changed my own server's addons/source-python/plugins/es_emulator/eventscripts/esc/cmds/run.py back to what it was prior to the update as seen below:
This does mean that I cannot use es_delayed without adding an additional es to the console when I wish to do some testing that involves delays, but the alternative is that a lot of scripts will break, which will affect every player on the servers.
So, in my opinion, this is definitely the lesser of two evils, and I would recommend changing it back to this as well, at last until a full fix is found, as it is far less damaging.
I am running the newest version of Source-Python, and the Emulator and Warcraft-Source.
The text was updated successfully, but these errors were encountered: