Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect The User To Back When Query Fails / Redirigir al usuario de Nuevo Cuando La Consulta Falla #38

Open
heliomar-pena opened this issue Jun 3, 2022 · 4 comments
Labels
bug Something isn't working EE-2 Estimation Effort 2 Grammar review javascript Pull requests that update Javascript code skill-medium This issue needs intermediate knowledges to be completed Translated vue Changes that needs vuejs e knowledges

Comments

@heliomar-pena
Copy link
Contributor

heliomar-pena commented Jun 3, 2022

Explanation:

Currently only one message is displayed, but the user is in an empty view, I think the user should be redirected when a query fails.

Screenshots:

image

Reproduce the error:

  1. Go to implementation.
  2. Enter a fake vendor id or similar to get a "Vendor Not Found" error. For example, you can enter this link: https://deploy-preview-36--did-app.netlify.app/#/providers/a5528fa5-ffd9-4943-89fe-1a06b4a6a082
  3. You should see an error notification, but you are not redirected.

Spanish Version:

Explicación:

Actualmente, solo se muestra un mensaje, pero el usuario está en una vista vacía, creo que se debe redirigir al usuario cuando falla una consulta.

Capturas de pantalla:

imagen

Reproducir el error:

  1. Ir a la implementación.
  2. Ingrese una identificación falsa de proveedor o similar para obtener un error de "Proveedor no encontrado". Por ejemplo, puede ingresar en este enlace: https://deploy-preview-36--did-app.netlify.app/# /proveedores/a5528fa5-ffd9-4943-89fe-1a06b4a6a082
  3. Debería ver una notificación de error, pero no eres redirigido.
@heliomar-pena heliomar-pena added bug Something isn't working javascript Pull requests that update Javascript code vue Changes that needs vuejs e knowledges skill-medium This issue needs intermediate knowledges to be completed labels Jun 3, 2022
@e-azocar
Copy link

e-azocar commented Jun 3, 2022

@katsu08 why this issue has react label if is abou vue?

@heliomar-pena
Copy link
Contributor Author

@katsu08 why this issue has react label if is abou vue?

My mistake, I've edited the label, now should be fine. Thanks for notifying !

@Israel-Laguan
Copy link

What about redirecting to "/" (Home) to avoid issues with unexpected states, for example when a user uses a link to enter a view then there is no "back" in history, so the user won't move.

Please check if that concern is applicable

@CARPER11 CARPER11 added this to the Tareas de mejora tecnica milestone Jun 13, 2022
@anaceciliamolinares anaceciliamolinares changed the title Redirect the user to back when query fails Redirect The User To Back When Query Fails / Redirigir al usuario de Nuevo Cuando La Consulta Falla Jul 13, 2022
@Eghinner Eghinner added the EE-2 Estimation Effort 2 label Sep 7, 2022
@JeysonG JeysonG self-assigned this Sep 12, 2022
@elier-fermin
Copy link

Hola, me gustaria saber si esta asignatura ya fue realizada?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EE-2 Estimation Effort 2 Grammar review javascript Pull requests that update Javascript code skill-medium This issue needs intermediate knowledges to be completed Translated vue Changes that needs vuejs e knowledges
Projects
None yet
Development

No branches or pull requests

8 participants