Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include arguments in errors #11341

Open
Tracked by #9456
spypsy opened this issue Jan 19, 2025 · 0 comments · May be fixed by #11211
Open
Tracked by #9456

Include arguments in errors #11341

spypsy opened this issue Jan 19, 2025 · 0 comments · May be fixed by #11211

Comments

@spypsy
Copy link
Member

spypsy commented Jan 19, 2025 •
edited
Loading

we currently format viem errors to truncate long hex arguments in order to keep logging cleaner and more readable.
However we should still be including the args along with any other useful information as the data object in logger.error()
e.g.:
logger.error('Failed to send tx', formattedError, errorObj)
@spypsy spypsy mentioned this issue Jan 19, 2025
Open
@spypsy spypsy changed the title Include arguments in Error Include arguments in errors Jan 19, 2025
@spypsy spypsy linked a pull request Jan 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use simulation to estimate gas used AztecProtocol/aztec-packages
1 participant
@spypsy