From 79a1c629d7825faa6ecf9d875900f88897c3be49 Mon Sep 17 00:00:00 2001 From: Mitchell Tracy Date: Tue, 18 Jun 2024 15:57:56 -0400 Subject: [PATCH] Add concern on simulation times. --- in-progress/6973-refactor-base-contract-interaction.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/in-progress/6973-refactor-base-contract-interaction.md b/in-progress/6973-refactor-base-contract-interaction.md index 197f73e..68ba630 100644 --- a/in-progress/6973-refactor-base-contract-interaction.md +++ b/in-progress/6973-refactor-base-contract-interaction.md @@ -1023,6 +1023,10 @@ export class BinarySearchGasEstimator implements GasEstimator { ### Concerns +#### Long time to simulate for gas estimation + +The binary search proposed in the gas estimation algorithm could add a lot of time needed for simulation. If/when we find this to be the case, we could impose an interface on FPCs to provide more information around how much gas the use of that FPC is going to cost, though the exact mechanism here is a bit unclear. + #### `UserRequest` is a kitchen sink The `UserRequest` object is a bit of a kitchen sink. It might be better to have a `DeployRequest`, `CallRequest`, etc. that extends `UserRequest`.