Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Data Mapper): Pass in loading as a normal prop since boolean behaves differently #6456

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

takyyon
Copy link
Contributor

@takyyon takyyon commented Jan 23, 2025

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

New Behavior

Impact of Change

  • This is a breaking change.

Test Plan

Screenshots or Videos (if applicable)

@takyyon takyyon requested a review from hartra344 as a code owner January 23, 2025 17:42
@takyyon takyyon enabled auto-merge (squash) January 23, 2025 17:42
@takyyon takyyon merged commit 643c8b0 into main Jan 23, 2025
12 checks passed
@takyyon takyyon deleted the krmitta/dm-testing-fix-1 branch January 23, 2025 18:00
takyyon added a commit that referenced this pull request Jan 24, 2025
takyyon added a commit that referenced this pull request Jan 27, 2025
…lic preview (#6470)

* Feat(Data Mapper): Panel with warning and error messages (#6315)

* started moving to v9 component

* api call works

* added value

* started test

* simplifying

* update to fix fluent ui bug

* component test passes

* fixed type error

* update version of fluent 9

* updated snapshots

* updated lockfile

* starting docs

* moved over v1 map checker

* simple panel works

* new error store

* added docs and displayed deserialization messages

* panels close when others open

* added required input checeker

* PR prep

* PR Comments

* updated yaml for tests

* feat(Data Mapper): Add keyboard delete, fix circles cutting, handle existing map loading (#6329)

* add keyboard delete

* only use delete when funciton or edge is selected

* remove backspace

* update width to handle circles cutting

* fix auto layouting

* Feat(Data Mapper): UX fixes for Public Preview (#6363)

* added new map placeholder

* added some colors

* custom info label

* PR prep

* Fix(Data Mapper): Sequence function serialization bug (#6378)

* fixed serialization issue

* test fix

* fix(Data Mapper): Fix circles cutting off (#6379)

data mapper update

* Fix(Data Mapper): bracket serialization bug (#6385)

* fixed bracket bug

* fixed typo in test

* feat(Data Mapper): Add notification to vscode from DM (#6390)

* setup vscode notification

* update toast to vscode

* fix(Data Mapper): Update Function config panel to fix wrapping, delete logic, placement of action items, info bubble  (#6393)

* dm font

* fix func config panel

* update function config 2

* fix style cherry-pick

* add remove logic

* fix margin

* feat(Data Mapper): Add info message and fix placeholders (#6405)

info message

* Fix(Data Mapper): add new files (#6396)

* starting using vscode file api

* fixing file fn

* file copy works and with schema imports

* error message works

* added info label

* fix(Data Mapper): Update height/width of panel and enhance Error/Warning panel (#6410)

* fix height

* enhance test panel

* fix(Data Mapper): Update string and open all functions by default (#6413)

open by default

* update strings

* merge main

* merge

* merge string changes

* update string

* Feat(Data Mapper): Loop message when users try to find loop in functions (#6451)

message works

* fix(Data Mapper): Fix unnecessary edge when node/parent is not in the search results (#6454)

* fix(Data Mapper): Pass in loading as a normal prop since boolean behaves differently (#6456)

loading passed

* fix(Data Mapper): Remove extra styling and clear out test results (#6459)

* update node position on search term change

* clear out test panel

* update circles

* fix(Data Mapper): Add subtitle for error/warning cards (#6464)

* node udpates

* add subtitle

---------

Co-authored-by: DanielleCogs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants