Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT DuckDB Version upgrade #567

Open
lesydimitri opened this issue Nov 18, 2024 · 1 comment
Open

MAINT DuckDB Version upgrade #567

lesydimitri opened this issue Nov 18, 2024 · 1 comment
Assignees

Comments

@lesydimitri
Copy link

Hi!

In my current workflow, I occasionally export PyRIT's results to Excel files. However, when using Python 3.12, my script that converts DuckDB entries to Excel in PyRIT silently crashed.

Upon investigating, I noticed that the project is locked to DuckDB version 0.10.0 in the pyproject.toml file.

Is there a specific reason for using this version? Running my conversion script with DuckDB 1.1.3 no longer crashes Python 3.12 and doesn't appear to affect PyRIT.

@romanlutz
Copy link
Contributor

Interesting! Thanks for raising this. I hadn't noticed that we're pinning this. I'm working through a bunch of issues before our next release, so I can look into upgrading to duckdb>=1.0.0 which is probably the difference between the failures and the working state that you're observing post-v1. I suspect this will require a few changes, though, since upgrades of the major version usually have breaking changes.

@romanlutz romanlutz changed the title DuckDB Version MAINT DuckDB Version upgrade Nov 19, 2024
@romanlutz romanlutz self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants