Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate str_begins in favor of stringr::str_starts #1

Open
aseagram opened this issue Feb 7, 2020 · 1 comment
Open

Deprecate str_begins in favor of stringr::str_starts #1

aseagram opened this issue Feb 7, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aseagram
Copy link

aseagram commented Feb 7, 2020

Deprecate (soft/hard) str_begins in favor of stringr::str_starts function; will require updated in related packages.

@aseagram aseagram added the enhancement New feature or request label Feb 7, 2020
@dholstius dholstius added the good first issue Good for newcomers label Apr 21, 2020
@dholstius
Copy link
Member

dholstius commented Apr 21, 2020

This is a great issue to get hands dirty editing our codebase!

@arihusain Let’s chat on Teams about the best way to handle this (are you comfortable branching, editing, and then sending a pull request)?

It’s not a critical issue, but is a good test/exercise of protocol precisely because it’s simple. And it’s a pattern that will come up again and again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants