From 012377b0c0fd0c285485d9c574215c533a99fb7e Mon Sep 17 00:00:00 2001 From: Pawel Baran Date: Wed, 14 Sep 2022 14:59:16 +0200 Subject: [PATCH 1/2] parameter type query tweaked to return null in case of invalid parameter types --- Revit_Core_Engine/Modify/SetParameter.cs | 2 +- Revit_Core_Engine/Query/ParameterType.cs | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Revit_Core_Engine/Modify/SetParameter.cs b/Revit_Core_Engine/Modify/SetParameter.cs index 6880a3dc5..e56d81c60 100644 --- a/Revit_Core_Engine/Modify/SetParameter.cs +++ b/Revit_Core_Engine/Modify/SetParameter.cs @@ -324,7 +324,7 @@ public static bool SetParameter(this Parameter parameter, object value, Document return parameter.Set(boolValue ? 1 : 0); } - if (parameter.HasValue && parameter.Definition.GetDataType() == null) + if (parameter.HasValue && parameter.Definition.ParameterType() == null) { string val = parameter.AsValueString(); if (val == valueString) diff --git a/Revit_Core_Engine/Query/ParameterType.cs b/Revit_Core_Engine/Query/ParameterType.cs index 34190acfb..14befda05 100644 --- a/Revit_Core_Engine/Query/ParameterType.cs +++ b/Revit_Core_Engine/Query/ParameterType.cs @@ -46,7 +46,11 @@ public static partial class Query #else public static ForgeTypeId ParameterType(this Definition definition) { - return definition.GetDataType(); + ForgeTypeId result = definition?.GetDataType(); + if (string.IsNullOrWhiteSpace(result?.TypeId)) + result = null; + + return null; } /***************************************************/ From 9cfddd6685794b2231dbe62fb213695ac82a9603 Mon Sep 17 00:00:00 2001 From: Pawel Baran Date: Wed, 14 Sep 2022 14:59:39 +0200 Subject: [PATCH 2/2] vertical column type set to Vertical by default --- Revit_Core_Engine/Convert/Physical/ToRevit/FamilyInstance.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Revit_Core_Engine/Convert/Physical/ToRevit/FamilyInstance.cs b/Revit_Core_Engine/Convert/Physical/ToRevit/FamilyInstance.cs index 55ac2417e..13860a47c 100644 --- a/Revit_Core_Engine/Convert/Physical/ToRevit/FamilyInstance.cs +++ b/Revit_Core_Engine/Convert/Physical/ToRevit/FamilyInstance.cs @@ -125,6 +125,9 @@ public static FamilyInstance ToRevitFamilyInstance(this Column framingElement, D familyInstance.get_Parameter((BuiltInParameter.FAMILY_BASE_LEVEL_OFFSET_PARAM)).Set(-1e+3); familyInstance.get_Parameter((BuiltInParameter.FAMILY_TOP_LEVEL_OFFSET_PARAM)).Set(1e+3); + if (locationLine.IsVertical()) + familyInstance.SetParameter(BuiltInParameter.SLANTED_COLUMN_TYPE_PARAM, 0); + familyInstance.CopyParameters(framingElement, settings); familyInstance.SetLocation(framingElement, settings);