You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following dune environment variables are set in the core, harpoon and optparser packages.
These globally disable compilation warnings such as unused variables.
However, what I find alarming is that warnings about not exhaustive pattern-matching are also suppressed.
This explains why there are not easily reproducible pattern-matching errors thrown in Harpoon sessions.
Where not exhaustive pattern-matching is intended as in the following, then warnings should be explicitly suppressed with macros like [@warning "-8"] instead of being toggled off globally.
There's really a lot of non-exhaustive pattern matches, so it's hard to enable the warning. An affordable solution would be handling them one-by-one (though it will still take long time)
The following dune environment variables are set in the
core
,harpoon
andoptparser
packages.These globally disable compilation warnings such as unused variables.
However, what I find alarming is that warnings about not exhaustive pattern-matching are also suppressed.
This explains why there are not easily reproducible pattern-matching errors thrown in Harpoon sessions.
Beluga/src/core/dune
Lines 7 to 9 in 3db1ffd
Beluga/src/harpoon/dune
Lines 6 to 8 in 3db1ffd
Beluga/src/optparser/dune
Lines 3 to 5 in 3db1ffd
Where not exhaustive pattern-matching is intended as in the following, then warnings should be explicitly suppressed with macros like
[@warning "-8"]
instead of being toggled off globally.Beluga/src/core/error.ml
Lines 116 to 122 in 3db1ffd
Fixing this issue won't be easy as it affects most files.
The text was updated successfully, but these errors were encountered: