Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client] Use production everywhere #1080

Closed
edisontim opened this issue Jul 5, 2024 · 1 comment · Fixed by #2130
Closed

[client] Use production everywhere #1080

edisontim opened this issue Jul 5, 2024 · 1 comment · Fixed by #2130
Assignees
@aymericdelab

Comments

@edisontim
Copy link
Collaborator

If we rename production manager to ResourceManager, we use a principle of Clean Code (one interface for all things similar) to only use this interface for all places where we use resources
The production manager doesn't cause any re-renders in case the resource isn't being produced
@ponderingdemocritus
Copy link
Contributor

This is good idea. @aymericdelab jump on this next

aymericdelab added a commit that referenced this issue Nov 20, 2024
@aymericdelab
[client] Use production everywhere
6d0779e 
Fixes #1080
@aymericdelab aymericdelab mentioned this issue Nov 20, 2024
Merged
aymericdelab added a commit that referenced this issue Nov 22, 2024
@aymericdelab
[client] Use production everywhere (#2130)
58b4e95 
* [client] Use production everywhere
Fixes #1080

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aymericdelab aymericdelab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[client] Use production everywhere BibliothecaDAO/eternum
3 participants
@aymericdelab @edisontim @ponderingdemocritus