Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken images in the contribution.md file of this repo #18

Open
TimOsahenru opened this issue Aug 26, 2024 · 8 comments
Open

Fix broken images in the contribution.md file of this repo #18

TimOsahenru opened this issue Aug 26, 2024 · 8 comments

Comments

@TimOsahenru
Copy link

You can create an assets/images folder and add the relevant files using this REPO as a guide or source of truth on what files to include in the assets/images

@TimOsahenru TimOsahenru changed the title Fix broken images in the contribution.md file of this repo Fix broken images in the contribution.md file of this repobugs Aug 26, 2024
@TimOsahenru TimOsahenru changed the title Fix broken images in the contribution.md file of this repobugs Fix broken images in the contribution.md file of this repo Aug 26, 2024
@mbvgua
Copy link
Contributor

mbvgua commented Sep 16, 2024

Yes images would better help one visualize this.

But a follow up question that adds on that: since this specific repo only has markdown files(as compared to the github.io repo that needs alot of dependecies and packages installed), wouldnt it be easier and better if people were to work on them in their local environment using their favourite editor instead of the Codespaces?

@TimOsahenru
Copy link
Author

Not sure what you mean, do you mind clarifying? Mind you, this issue is to fix the broken images in this file https://github.com/BlackPythonDevs/.github/blob/main/CONTRIBUTING.md

@mbvgua
Copy link
Contributor

mbvgua commented Sep 16, 2024

Okay, great. Your link directs to the page below:

Screenshot from 2024-09-16 18-58-24

And I think that you are proposing for the links to be fixed such that they will resemble the main repo as below:

Screenshot from 2024-09-16 19-09-08

Your proposed solution would aim for the images to direct one on how to develop on the Github Codespaces. I am building on your idea by proposing that for this specific repo, instead of working in the codespaces we could instead work in a local environment, whereby after forking the repo you clone it to your device then begin contributing.

If these were the case, the images that would need to be uploaded would not have to for codespaces as you suggested, but instead ones guiding you on how to develop locally.

@TimOsahenru
Copy link
Author

Gotcha! Well this issue is to help those contributing using the codespace but, can’t make meaningful sense out of it cos of the broken images

@TimOsahenru
Copy link
Author

If there isn’t an issue that deals with contributing locally I’d suggest you create one

@mbvgua
Copy link
Contributor

mbvgua commented Sep 16, 2024

Yes. I also agree that would be better way forward. Let me do that immediately

@TimOsahenru
Copy link
Author

Ensure you confirm that issue has not already been created. Check this out BlackPythonDevs/blackpythondevs.github.io#416 might be related to your issue

@mbvgua
Copy link
Contributor

mbvgua commented Sep 16, 2024

I think that the organisations repos are supposed to be independent of each other. Because if this were the case, the issue has not been raised on this repository, but if not I have seen it in another repo here .

Edit: after thorough consideration, I think I will just close the issue i had created. If it is fixed on the main repo the changes might reflect here too.

If not, ill be sure to open it again 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants