Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not ignoring hardcoded variable variable.is_enchanted #93

Open
Xterionix opened this issue Mar 19, 2024 · 3 comments
Open

Not ignoring hardcoded variable variable.is_enchanted #93

Xterionix opened this issue Mar 19, 2024 · 3 comments

Comments

@Xterionix
Copy link
Contributor

Xterionix commented Mar 19, 2024

image
Should not flag this as an error, at least when used in an attachable

@DaanV2 DaanV2 transferred this issue from Blockception/BC-Minecraft-Bedrock-Diagnoser Mar 19, 2024
@Xterionix
Copy link
Contributor Author

Xterionix commented May 4, 2024

https://github.com/Blockception/BC-Minecraft-Bedrock-Diagnoser/blob/main/src/Lib/Diagnostics/Molang/diagnostics.ts#L150

Doesn't this mean it should be transferred back to the diagnoser?

if (InternalIdentifiable.has(MolangData.get(owner)?.Variables ?? [], check)) continue;

Or maybe not?

@DaanV2
Copy link
Contributor

DaanV2 commented May 5, 2024

Think it should be defined as an item variable 🤔 or attachable

@Xterionix
Copy link
Contributor Author

Anything I can do to help move this along?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants