Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo says msrv is 1.41.1 but CI tests 1.56 #83

Closed
stevenroose opened this issue Sep 21, 2024 · 1 comment · Fixed by #84
Closed

Repo says msrv is 1.41.1 but CI tests 1.56 #83

stevenroose opened this issue Sep 21, 2024 · 1 comment · Fixed by #84

Comments

@stevenroose
Copy link
Contributor

I noticed that @sanket1729 's musig branch isn't building in 1.41.1, I didn't try master, but since it's a secp-sys issue, I would expect master to also not build.

Did the msrv bump to 1.56? Then the readme is outdated.
@apoelstra
Copy link
Contributor

Yep, oops. We bumped the MSRV in #75 but forgot to update the README.

@jonasnick jonasnick mentioned this issue Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

README: fix MSRV jonasnick/rust-secp256k1-zkp
2 participants
@stevenroose @apoelstra