Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up marshalling messages #383

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 2, 2025

Enums never change, only resolve them once
Screenshot 2025-02-02 at 4 44 51 PM

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (89026e3) to head (d133f1e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   83.88%   84.00%   +0.12%     
==========================================
  Files          28       28              
  Lines        3381     3388       +7     
  Branches      607      607              
==========================================
+ Hits         2836     2846      +10     
+ Misses        338      334       -4     
- Partials      207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 2, 2025

CodSpeed Performance Report

Merging #383 will improve performances by 4.12%

Comparing outgoing_message_values (d133f1e) with main (89026e3)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_marshall_bluez_get_managed_objects_message 73 µs 70.1 µs +4.12%

@bdraco bdraco closed this Feb 2, 2025
@bdraco bdraco reopened this Feb 2, 2025
@bdraco bdraco marked this pull request as ready for review February 2, 2025 22:51
@bdraco bdraco merged commit d7213be into main Feb 2, 2025
37 checks passed
@bdraco bdraco deleted the outgoing_message_values branch February 2, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant