Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/issues 253 adds vr impact #368

Merged
merged 8 commits into from
Feb 9, 2025
Merged

Feat/issues 253 adds vr impact #368

merged 8 commits into from
Feb 9, 2025

Conversation

ju3ouz4n
Copy link
Contributor

@ju3ouz4n ju3ouz4n commented Jan 22, 2025 •
edited
Loading

Fixes #253

  • New routes added for VR headset and controller.

  • Made some assumptions about impact values, i'm really not sure about the numbers :/

    • usage.avg_power seems odd compared to other values, and i don't know how to compute min and max
    • not sure about the source in factor.yml
    • not sure about the numbers, should i break down impact into phase (eol, manufacture, distribution?) like in the excel file ?
    • Please check both commits : dd4d311 and 52460c8

  • The routes seems to be correctly plugged, up and running.

When i'm sure about the numbers i'll add some tests and doc.

@da-ekchajzer
Copy link
Collaborator

da-ekchajzer commented Feb 1, 2025 •
edited
Loading

Hey, thank you very much for this PR ! You did.

  • The hypotheses chosen seem coherent to me
  • The source of the impact factors is wrong (but i didn't give it some my bad.

It is not "Adapted by Tide from 'Assessing the embodied carbon footprint of IoT edge devices with a bottom-up life-cycle approach', 2021; Thibault Pirson et David Bol (Université catholique de Louvain, ICTEAM/ECS, Louvain-la-Neuve, Belgique)" but CEPIR : Cas d'Étude Pour un Immersif Responsable, 2022

  • Not a problem that there a no test since the impacts functions are generic an already tested

I came across a bug that predates your PR while testing it. I push a fix before merge. #370

@ju3ouz4n
Copy link
Contributor Author

ju3ouz4n commented Feb 3, 2025

Hey @da-ekchajzer , just updated data sources on factors.yml.
Do you want me to rebase the feature branch when #370 is merged to main branch?

@da-ekchajzer da-ekchajzer changed the base branch from main to dev February 4, 2025 17:19
@da-ekchajzer
Copy link
Collaborator

I changed the target branch to dev. It is nice if you rebase :). I will to some final check and then merge.

Thank you !

@ju3ouz4n ju3ouz4n force-pushed the feat/issues-253-adds-vr-impact branch from 3cbd834 to 7951ced Compare February 4, 2025 22:04
@ju3ouz4n
Copy link
Contributor Author

ju3ouz4n commented Feb 4, 2025

Hi @da-ekchajzer, just finished the rebase, it was not trivial 😅 'cause i had already merged some commits from the main branch earlier. Should be ok now!

@da-ekchajzer
Copy link
Collaborator

da-ekchajzer commented Feb 9, 2025 •
edited
Loading

Perfect for me, thank you! I just corrected a small typo on adpe but everything is fine with me. Sorry for the delay, it has been a tough month.

I will immediately add the VR headset and controller to the documentation.

@da-ekchajzer da-ekchajzer merged commit 1ab2d95 into Boavizta:dev Feb 9, 2025
3 checks passed
@da-ekchajzer da-ekchajzer mentioned this pull request Feb 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding VR headset impacts evaluation
2 participants
@ju3ouz4n @da-ekchajzer