Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint git action #550

Open
jpolton opened this issue Sep 16, 2022 · 5 comments
Open

pylint git action #550

jpolton opened this issue Sep 16, 2022 · 5 comments
Assignees

Comments

@jpolton
Copy link
Collaborator

jpolton commented Sep 16, 2022

Create a GitAction to run pylint test.
This would help with keeping the code readable and all that.
Currently a problem because there are too many fails. (Probably mostly from missing doc strings)

@thogar-computer
Copy link
Member

Try to setup pylint so that it will fail if more errors are added to the code base. i.e. set minium pass level. also look into pre-commit hooks

@soutobias soutobias self-assigned this Oct 31, 2023
@soutobias soutobias moved this from BODC - Todo to BODC - In Progress in COAsT_dev Oct 31, 2023
@soutobias
Copy link
Collaborator

I have established a 'pylint.yml' configuration file to automate pylint checks on the github actions. After running pylint, the resulting code quality score is compared to the value stored in the '.pylint-score' file. If the newly calculated score exceeds the value stored in the file, the test will pass. Subsequently, the value in the '.pylint-score' file is updated. This ensures that any new code additions maintain or improve upon the existing code quality score.

@soutobias
Copy link
Collaborator

#633

@thogar-computer
Copy link
Member

Reminder to add in diagram to coast site of new github action work flow

@soutobias
Copy link
Collaborator

@thogar-computer , mermaid diagram added to the coast-site:

Image

@soutobias soutobias moved this from BODC - In Progress to Merged to Develop in COAsT_dev Nov 2, 2023
@soutobias soutobias moved this from Merged to Develop to Done in COAsT_dev Nov 7, 2023
@soutobias soutobias moved this from Done to Merged to Develop in COAsT_dev Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged to Develop
Development

No branches or pull requests

3 participants