Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered pyrenew_demo.md is out of date with pyrenew_demo.qmd #81

Closed
damonbayer opened this issue Apr 15, 2024 · 4 comments
Closed

Rendered pyrenew_demo.md is out of date with pyrenew_demo.qmd #81

damonbayer opened this issue Apr 15, 2024 · 4 comments

Comments

@damonbayer
Copy link
Collaborator

It appears that not all of the changes to the .qmd file in #77 made it all the way to the rendered .md file. I'm not sure if this was supposed to happen automatically.

@damonbayer
Copy link
Collaborator Author

damonbayer commented Apr 15, 2024

Also note from the diff in #77 that the output is not completely reproducible. The code is the same, but the table and figures are not.

@gvegayon
Copy link
Member

It appears that not all of the changes to the .qmd file in #77 made it all the way to the rendered .md file. I'm not sure if this was supposed to happen automatically.

Not just yet, but that could be the next step!

@gvegayon
Copy link
Member

Also note from the diff in #77 that the output is not completely reproducible. The code is the same, but the table and figures are not.

That's right, @damonbayer. Thanks for flagging that. This is important regarding #4 as, besides the tutorial, the tests should work OK. I'll investigate what's the issue here.

@gvegayon
Copy link
Member

Reproducibility in Python is tricky, especially for figures. #55 added a pytest comparing figures with some tolerance to change. I'm closing this as #4 still will address some of the problems (and the qmd and md files are now synced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants