Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle underflows more consistently #171

Closed
eclare108213 opened this issue Feb 13, 2018 · 1 comment
Closed

handle underflows more consistently #171

eclare108213 opened this issue Feb 13, 2018 · 1 comment
Labels
Type: Duplicate

Comments

@eclare108213
Copy link
Contributor

The way we handle underflows is not consistent throughout the code. We should revisit that. In particular, the exp_argmax value varies across the code.
@apcraig apcraig closed this as completed Feb 13, 2018
@apcraig
Copy link
Contributor

apcraig commented Feb 13, 2018

#170 got there first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eclare108213 @apcraig