-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xydisplay - phase input, interpolated point disapears #138
Comments
@damienjacquet Thanks for this and apologies for the late reply. This is indeed a bug. The root of the issue in your example seems to be that the x-coordinates for both points 5 and 6 are identical. In the code, this leads to a divide by zero, resulting in NaN being returned. The problem is actually worse than this; it appears that the y-values that are returned by interpolation are incorrect.
TODO: in xydisplay.c the xy_scale method needs to check for scenarios where inputs will result in divide by zero. TODO: find the source of inaccuracy in y-value interpolation |
I have attempted a tentative fix for this issue pending review by @maccallum, who is the original author. In the meantime, try it out below. |
thank you for the fix, I will test it as soon as I can |
@wagne342 Do you have a .mxe64 version of the objects ? I would like to test it on windows |
@wagne342 that fix looks good to me |
I use xydisplay to create trajectories in a spatialization software to move a sound source.
when interpolating the points to place the source along the trajectory, the interpolated point sometimes disappears.
-nan(ind) is give as a y coordinate
here is an example patch of the bug:
bug_xydisplay_interpolated_point_nan.txt
221124_xydisplay_source_disappears.mov
The text was updated successfully, but these errors were encountered: