1-bit convenience setters not working as expected (in CAN, potentially others)

[SebastianSchildt]

ACF-CAN offers convenience funtions to set fields, e.g.

Open1722/src/avtp/acf/Can.c

Lines 166 to 169 in 7fe06a3

	void Avtp_Can_SetEff(Avtp_Can_t* pdu, uint8_t value)
	{
	SET_FIELD(AVTP_CAN_FIELD_EFF, value);
	}

This works fine for all fiedls with "int" semantics, but does not behave as expected for 1 bit fields with bool semantic.

In C you might do

    Avtp_Can_SetEff(&pdu.can, cf->can_id & CAN_EFF_FLAG);

where according to C sematics cf->can_id & CAN_EFF_FLAG evaluates to true for extended frame identifiers, however as CAN_EFF_FLAG is defined as

#define CAN_EFF_FLAG 0x80000000U /* EFF/SFF is set in the MSB */

the value is not set.

I would suggest to change the convenicence functions for 1 Bit Ids, e.g. to

void Avtp_Can_SetEff(Avtp_Can_t* pdu, uint64_t value)
{
    if (value) {
        SET_FIELD(AVTP_CAN_FIELD_EFF, 1);
    } else {
        SET_FIELD(AVTP_CAN_FIELD_EFF, 0);
    }
}

The generic Avtp_Can_SetField and the even more generic Avtp_SetField(Avtp_CanFieldDesc, AVTP_CAN_FIELD_MAX, (uint8_t*)pdu, field, value). exhibit the same behavior, but I would not overcomplicate those with "special" boolean handling (they would need to have special handling depending on field description), but only choose the highest level direct access convenience functions as in the example