Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalid characters in branch name when building dev PR container image #341

Open
CarrotManMatt opened this issue Sep 27, 2024 · 0 comments
Labels
bug Something isn't working deployment Changes to the deployment or CI/CD configuration

Comments

@CarrotManMatt
Copy link
Member

When a PR is made and a dev container is automatically built with the name of the branch, if the branch contains any invalid characters the build will fail. A step should be added to the build workflow file to replace any invalid characters in the branch name string and use than new string as the name of the built image.

@CarrotManMatt CarrotManMatt added bug Something isn't working deployment Changes to the deployment or CI/CD configuration labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Changes to the deployment or CI/CD configuration
Projects
None yet
Development

No branches or pull requests

1 participant