Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing d-tiler #85

Open
rajopadhye opened this issue Jun 11, 2024 · 0 comments
Open

Fixing d-tiler #85

rajopadhye opened this issue Jun 11, 2024 · 0 comments
Assignees

Comments

@rajopadhye
Copy link

I was speaking to Campbell about the options for him to be able to get wavefront parallelized d-tiled code and the bug that was previously fixed in an ad-hoc way previously. He suggested that could try to fix d-tiler, and we had a brief exchange -- the fix is conceptually really simple, IMHO. Here's what I sent him

Hi Campbell,

Here’s the link to the pdf of his dissertation. You want to look specifically at Ch 8 (starting page 82). the error is in the two formulae for computing the first and last tile. What is needed is to:

  1. Compute the vertices of the outset (not from the loop bounds, but rather, by an isl call — these are all parametric function of the program parameters and tile sizes.

  2. Then, first and last are given by:

first = min_i \sum_j frac{V_i_j}{s_j}
last = max_i \sum_j frac{V_i_j}{s_j}

v_i_j is the j’th dimension of the ith vertex, and s_j is the tile size in dimension j.

Oe thing I forgot to ass is that the lower bounds have to be rounded up to the next multiple of the tile size in that dimension.

@ryanjob42 ryanjob42 assigned ryanjob42 and unassigned ryanjob42 Jun 13, 2024
@JCampbellBradley JCampbellBradley self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants