Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable string comparison for LLVM generator tests #99

Open
Ailrun opened this issue Aug 31, 2019 · 2 comments
Open

Use readable string comparison for LLVM generator tests #99

Ailrun opened this issue Aug 31, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Ailrun
Copy link
Member

Ailrun commented Aug 31, 2019

Is your feature request related to a problem? Please describe.
Current LLVM-generator tests are nearly impossible to parse. When a problem occurs, it involves significant amount of mental energy to find what the problem is.

Describe the solution you'd like
Use more readable, line-separated, easy-to-diff strings instead of unparsible data type.

Additional context
Is there any case that a stringification mangles different data types into the same string?

@Ailrun Ailrun added the enhancement New feature or request label Aug 31, 2019
@Ailrun
Copy link
Member Author

Ailrun commented Sep 5, 2019

Or are there any other testing frameworks that support an error-formatting functionality?

@Ailrun
Copy link
Member Author

Ailrun commented Nov 26, 2019

I think if there is any pretty print library for LLVM, a single newtype wrapper would solve the problem, by defining a custom Show instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant