Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the CveCore and CveRecord classes #15

Open
hkong-mitre opened this issue Sep 18, 2023 · 2 comments
Open

simplify the CveCore and CveRecord classes #15

hkong-mitre opened this issue Sep 18, 2023 · 2 comments
Labels
refactor

Comments

@hkong-mitre
Copy link
Collaborator

There are a total of 4 classes dealing with various depth of CveRecord: CveCore, CveCorePlus, CveRecordV5, and CveRecord.

For CveCore and CveCorePlus, this can probably be merged into a single class now that the delta format is simplified.

For CveRecordV5 and CveRecord, we need to determine how much of the auto generated classes we're actually leveraging, and whether keeping it makes sense anymore.
@hkong-mitre hkong-mitre mentioned this issue Sep 18, 2023
Merged
@hkong-mitre
Copy link
Collaborator Author

address the postponed comment from PR #13 (comment)

@hkong-mitre
Copy link
Collaborator Author

Issue #5 may also be considered by this refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkong-mitre