Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axograph_readwrite? #4

Open
jpgill86 opened this issue Jun 9, 2018 · 0 comments
Open

Update axograph_readwrite? #4

jpgill86 opened this issue Jun 9, 2018 · 0 comments

Comments

@jpgill86
Copy link
Member

jpgill86 commented Jun 9, 2018

With AxoGraph X 1.7.0 (likely much earlier), changes were introduced to the developer's interface provided with the software in the axograph_readwrite directory. These files have begun to diverge from the copies included in this repository (see here for files as of 8ccf296). It might be good to update the axographio package to use the latest versions of these files.

The new files: axograph_readwrite-1.7.0.zip

The changes are relatively minor (mostly type changes), but after putting a little time into it I was unable to get the package to work with them. The main issue seems to be that support for non-Mac platforms in fileUtils.cpp was completely dropped, and the code now completely relies on Apple's (deprecated) Carbon API. Even when I put back in the necessary pieces of this file for compiling the package on non-Mac platforms (everything below this line), Python aborts without any error messages when axographio.read() is executed. Managing file pointers seems to be the problem.

At this time, updating the package to use the latest axograph_readwrite seems like more trouble than it's worth. However, since I've already invested some time, I thought I'd at least document what I learned and provide this patch which contains my efforts so far, and which can be applied to 8ccf296:

Work in progress: update-axograph_readwrite.patch.txt

@jpgill86 jpgill86 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant