From df414800e67fa5e63c75a5c1ad5b3de9eced959a Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 23 Jan 2024 17:04:46 -0500 Subject: [PATCH] Add TODOs for later changes --- .github/actions/check-for-CLA/index.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/actions/check-for-CLA/index.js b/.github/actions/check-for-CLA/index.js index 8a2043911bac..5ded3db318dc 100644 --- a/.github/actions/check-for-CLA/index.js +++ b/.github/actions/check-for-CLA/index.js @@ -12,8 +12,7 @@ const PULL_REQUST_INFO = { gitHubToken: process.env.GITHUB_TOKEN }; -/* TODO: Replace with actual Cesium spreadsheet Ids - these are test sheets that I'll delete, so okay to git push */ -/* TODO: Then store in repo secrets */ +/* TODO: 1. Replace with actual Cesium CLA spreadsheet Ids, 2. Retrieve Ids from GitHub Secrets, not expose */ const GOOGLE_SHEETS_INFO = { individualCLASheetId: '1oRRS8OG4MfXaQ8uA4uWQWukaOqxEE3N-JuqzrqGGeaE', corporateCLASheetId: '1dnoqifzpXB81G1V4bsVJYM3D19gXuwyVZZ-IgNgCkC8' @@ -59,8 +58,7 @@ const checkIfUserHasSignedAnyCLA = async () => { const getGoogleSheetsApiClient = async () => { const auth = new google.auth.GoogleAuth({ - // TODO: get from GitHub secrets - // (JSON contains keys for my personal Service account that isn't used for anything else, so okay to git push) + // TODO: 1. Get similar config file for Cesium Google account, 2. Retrive file from secrets and remove from source control keyFile: 'TempGoogleConfig.json', scopes: ['https://www.googleapis.com/auth/spreadsheets'] }); @@ -139,7 +137,7 @@ const postCommentOnPullRequest = async (hasSignedCLA, errorFoundOnCLACheck) => { const getCommentBody = (hasSignedCLA, errorFoundOnCLACheck) => { console.log('getting comment template...'); - const commentTemplate = fs.readFileSync('./.github/actions/check-for-cla/templates/pullRequestComment.hbs', 'utf-8'); + const commentTemplate = fs.readFileSync('./.github/actions/check-for-CLA/templates/pullRequestComment.hbs', 'utf-8'); const getTemplate = Handlebars.compile(commentTemplate); const commentBody = getTemplate({ errorCla: errorFoundOnCLACheck,