Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send validator registrations as SSZ instead of JSON #7369

Open
nflaig opened this issue Jan 16, 2025 · 0 comments
Open

Send validator registrations as SSZ instead of JSON #7369

nflaig opened this issue Jan 16, 2025 · 0 comments
Labels
meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.

Comments

@nflaig
Copy link
Member

nflaig commented Jan 16, 2025

See ethereum/builder-specs#110

Right now we limit this api to send JSON-only

lodestar/packages/api/src/builder/routes.ts

Line 93 in 0ac8bb9

req: JsonOnlyReq({

Our HTTP client will already fallback to JSON if we receive a 415 status code but we will have to add custom retry logic for this specific call to consider any HTTP error (but not network errors) and if we encounter an error we should only send JSON afterwards.
@nflaig nflaig added the meta-feature-request Issues to track feature requests. label Jan 16, 2025
@philknows philknows added the scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nflaig @philknows