Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constantly check mentions and queue scans #11

Open
Chaphasilor opened this issue Mar 9, 2021 · 1 comment
Open

Constantly check mentions and queue scans #11

Chaphasilor opened this issue Mar 9, 2021 · 1 comment
Assignees
@Chaphasilor
Labels
enhancement Improves an existing feature waiting for release The issue has been fixed in another branch and is on its way to the main branch

Comments

@Chaphasilor
Copy link
Owner

Right now, if a scan is running and it takes a long time, the bot won't check for new mentions until the scan is finished.
If the scan takes longer than the mention stale timeout, invocations might be missed.

To solve this, always check for mentions and add any mention to a queue (with submission, comment, url?, etc.).
The queue can be checked once a scan has finished and when a new mention is added.
@Chaphasilor Chaphasilor added the enhancement Improves an existing feature label Mar 9, 2021
@Chaphasilor Chaphasilor self-assigned this Mar 9, 2021
@Chaphasilor
Copy link
Owner Author

this should be working on the dev branch already

@Chaphasilor Chaphasilor added the waiting for release The issue has been fixed in another branch and is on its way to the main branch label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chaphasilor Chaphasilor

Labels
enhancement Improves an existing feature waiting for release The issue has been fixed in another branch and is on its way to the main branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chaphasilor