Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column Uniqueness for active deals #86

Open
NikolasHaimerl opened this issue Feb 6, 2025 · 1 comment · May be fixed by #92
Open

Column Uniqueness for active deals #86

NikolasHaimerl opened this issue Feb 6, 2025 · 1 comment · May be fixed by #92

Comments

@NikolasHaimerl
Copy link
Contributor 

          Would it make it easier to update individual active deal rows if we added an auto-generated primary key so that we can simplify the WHERE condition to `WHERE id = $4` instead of comparing values in 9 columns?

Originally posted by @bajtos in #77 (comment)
@NikolasHaimerl NikolasHaimerl mentioned this issue Feb 6, 2025
Merged
@juliangruber
Copy link
Member

@NikolasHaimerl please post these issues in quotes, so one doesn't need to scroll to read the whole text:

> Would it make...

Would it make it easier to update individual active deal rows if we added an auto-generated primary key so that we can simplify the WHERE condition to WHERE id = $4 instead of comparing values in 9 columns?

@NikolasHaimerl NikolasHaimerl linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add serial id CheckerNetwork/spark-deal-observer
2 participants
@juliangruber @NikolasHaimerl