Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualize(::AtomGraph) should write to file #5

Open
jonathanmfung opened this issue Apr 13, 2022 · 1 comment
Open

visualize(::AtomGraph) should write to file #5

jonathanmfung opened this issue Apr 13, 2022 · 1 comment

Comments

@jonathanmfung
Copy link

Port of Chemellia/ChemistryFeaturization.jl#109

This should be easy enough. I think @sakshi-satyanand is going to take a crack at this :)

@jonathanmfung
Copy link
Author

jonathanmfung commented Apr 13, 2022

Since visualize(::AtomGraph) uses GraphPlot.gplot(), a user would have to use the Compose.jl library to save the figure.

It would be possible to reexport Compose.draw(), but that would add another dependency. Additionally, GraphPlot.jl does not reexport themselves. So, I would err on the side of leaving it up to the user.

The implicit return defined in #3 should be able to work with Compose.draw(), though I'm a bit rusty with Julia's handling of returns and plots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant