Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin setting to customize the player buffering behaviour #6816

Open
stemy2 opened this issue Jan 5, 2025 · 6 comments
Open

Admin setting to customize the player buffering behaviour #6816

stemy2 opened this issue Jan 5, 2025 · 6 comments

Comments

@stemy2
Copy link

stemy2 commented Jan 5, 2025

Describe the problem to be solved

Hello,

My connection is pretty slow, and i'd like to change the buffering behaviour to reduce the annoyance.

Describe the solution you would like

-Allow buffering when video is paused.
-Allow buffering until the end of the video once for all.

@frenzybiscuit
Copy link

-Allow buffering until the end of the video once for all.

No thank you! When you factor in high quality (40Mbps+ bitrate) 4k videos that could be up to an hour long loading the entire video into the buffer would be a complete nightmare!

You would be literally throwing away bandwidth on the server if the user closes the video before finishing it.

If you need this feature you should consider editing the source code and compiling peertube yourself from scratch!

Here is a guide for compiling:

https://docs.joinpeertube.org/install/unofficial

Also, PR's are welcome if you can get this feature to work in a way that won't be abused.

@stemy2
Copy link
Author

stemy2 commented Jan 5, 2025

I'm not advanced enough in coding to compile a such thing. Why not add the options in a server config file ? I intent using it on a confidential instance.

@frenzybiscuit
Copy link

-Allow buffering when video is paused.

It already does this!

@frenzybiscuit
Copy link

advanced enough in coding to compile a such thing. Why not add the options in a server config file ? I intent using it on a confidential instance.

Why don't you just enable video downloads and let users download the video?

It's literally the same thing if you want the entire video to load into the buffer.

@stemy2 stemy2 closed this as completed Jan 5, 2025
@Chocobozzz Chocobozzz reopened this Jan 6, 2025
@Chocobozzz
Copy link
Owner

Reopening this issue because an admin setting to customize the player buffer behaviour seems a good idea.

@Chocobozzz Chocobozzz changed the title Customise the buffering behaviour Admin setting to customize the buffering behaviour Jan 6, 2025
@Chocobozzz Chocobozzz changed the title Admin setting to customize the buffering behaviour Admin setting to customize the player buffering behaviour Jan 6, 2025
@frenzybiscuit
Copy link

Just curious, is there a limitation on how large the buffer can be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants