Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On prop-based styles (for extracted/compiled away values) #103

Open
kylpo opened this issue Mar 21, 2022 · 0 comments
Open

On prop-based styles (for extracted/compiled away values) #103

kylpo opened this issue Mar 21, 2022 · 0 comments

Comments

@kylpo
Copy link
Contributor

kylpo commented Mar 21, 2022

I, personally, really like this API. But, I have recently felt that it may not be the best.

The problem with prop-based styles of compile-time, extracted primitives: they deceive the user. They aren't native props that may be dynamic. They're a different kind of prop, that doesn't really have a way to identify itself as different. [idea: maybe a new naming convention could help? _width={50} to denote a compile-away value? This way, the user would know to not have anything dynamic here.]

Consider css={``} instead, since folks are more used to this being a special prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant