This repository has been archived by the owner on Aug 21, 2018. It is now read-only.
Iss07 #21
Open
Iss07 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert Tabs to Spaces
pip install Reindent reindent -r -v . <review changes comparing to *.bak>
Manually correct under and over-indented continuation lines. Use the following package and command to identify and ‘verify’ corrections: pip install flake8 flake8 . --select E101,E111,E114,E116,E122,E127,E128,E131,W191 --statistics
|
Hey @cmlccie do you want any help with this merge? |
|
I didn't have the rights to merge it. This PR is SO old, the work probably needs to be redone (as the code has likely changed). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indentation and whitespace corrections to fix #7.
I used the following process to make these corrections:
flake8to identify the files with indentation issues.Reindentpackage to make number of spaces per indent consistent (4 spaces).reindent’s changes (spot checked each of the files).flake8to identify various under and over-indented line continuations.flake8to verify there were no remaining reporting indentation issues.Tools and Commands Used