Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and expand countmatch.growthfactor #26

Open
4 tasks
cczhu opened this issue Nov 27, 2019 · 0 comments
Open
4 tasks

Clean up and expand countmatch.growthfactor #26

cczhu opened this issue Nov 27, 2019 · 0 comments
Assignees
Labels
refactoring Reworking code structure without (major) API changes

Comments

@cczhu
Copy link
Contributor

cczhu commented Nov 27, 2019

Right now growthfactor.py incorrectly uses factor to mean "rate" (whereby in TEPs-I it's a multiplicative factor). This has been corrected the countmatch_matcher branch, but we should clean up some of the outstanding issues, like the existence of a base year.

More generally, however, we should also consider point 2 in #25 - should we instead store the year-on-year growth rates (calculating growth rates for each year separately from other years), then allow subsequent methods to multiply these growth rates together to get prod(GR_k)?

Tasks:

  • Discuss a more reasonable growth factor calculation with Aakash. If we calculate growth only from a single year (multiplying growth factors from multiple years together), does that increase the noise? Should we be performing exponential fits on weekly or MADT data rather than just doing a two-point AADT fit?
  • Remove redundant attributes in PermCount, like base_year.
  • Swap from the multi-year fitting strategy to a single year fitting one, storing the growth factors from each year so we can multiply them together for multi-year growth.
  • Simplify the exponential fitting algorithm to a two-point AADT fit ln(AADT_1 / AADT_0) / (year_1 - year_0) like Arman uses.
@cczhu cczhu added the refactoring Reworking code structure without (major) API changes label Nov 27, 2019
@cczhu cczhu self-assigned this Nov 27, 2019
@cczhu cczhu changed the title Clean up and expand growthfactory.py Clean up and expand countmatch.growthfactor Nov 27, 2019
@cczhu cczhu mentioned this issue Mar 12, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Reworking code structure without (major) API changes
Projects
None yet
Development

No branches or pull requests

2 participants