Remaining issues with CC + Woo activation logic

[nylen]

After #173 and #175 Classic Commerce should be able to prevent a user from causing fatal errors by trying to activate both CC and Woo at the same time from within the normal UI, on a single-site installation. There are some special cases that are not yet covered:

• If a user is activating and deactivating plugins some other way (e.g. using WP-CLI or a management plugin), they will still be able to cause fatal errors by trying to activate both CC and Woo at the same time.
• I have not tested this activation logic on multisite installations but I suspect users can also cause fatal errors there. Remember that on multisite a plugin can be network activated or only activated for a single site, with different code paths for each case, which means there are more possible cases to test.
• There may still be other ways to break this.

I am not sure if these issues are a high enough priority to fix in the code (I am thinking probably not for version 1 unless we find other things that still don't work correctly). However these caveats do at least need to be documented for users, and this documentation needs to be included in release posts or linked from there so that people who want to try out CC will see it.

[timbocode]

You would probably break it by manually tweaking the database and adding entries for both woocommerce/woocommerce.php and classic-commerce/classic-commerce.php in active_plugins in the cp_options table but only an idiot would do that.

But you're right. There are bound to be some other cases where it will break but hopefully these will be discovered during alpha and beta testing.

When we announce the release of alpha3, we should specifically ask for testers.

[bahiirwa]

I have done some edits to @nylen's first comment for us to track the issue since it is 1.0.0-beta1