Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sale price end on midnight of sale day #343

Merged
merged 1 commit into from Oct 18, 2021
Merged

Make sale price end on midnight of sale day #343

merged 1 commit into from Oct 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2021

All Submissions:

Changes proposed in this Pull Request:

The end date for a sale should be midnight on the date set for the sale to end. It currently end at 00:00 on that day ie midnight of the day before.

Closes #342 .

How to test the changes in this Pull Request:

  1. Set a product to be on sale ending today (starting today or earlier)
  2. Visit the product page
  3. The sale price is not shown
  4. Make the change to the line in the file
  5. Visit the product page again
  6. The sale price now shows

Screenshot - before:

before

Screenshot - after:

after

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you included screenshots before/after your changes, if applicable?

@ghost ghost added the Bug fix Bug Fix label Sep 27, 2021
@ghost
Copy link
Author

ghost commented Oct 18, 2021

.

@ghost ghost closed this Oct 18, 2021
@nylen nylen reopened this Oct 18, 2021
@nylen nylen merged commit def09a6 into ClassicPress:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sale ends at 00:00 instead of 11:59 PM on set day
1 participant