Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from torequests to httpx. #148

Open
T-256 opened this issue Jun 3, 2024 · 1 comment
Open

migrate from torequests to httpx. #148

T-256 opened this issue Jun 3, 2024 · 1 comment

Comments

@T-256
Copy link
Contributor

T-256 commented Jun 3, 2024

less dependencies and lighter weight

@ClericPy
Copy link
Owner

ClericPy commented Jun 4, 2024

Indeed, I had planned to remove torequests from the ichrome library two years ago. The reason why I chose aiohttp at the beginning was that its concurrency capability was an order of magnitude higher than other libraries (httpx and requests are much slower).

On the one hand, aiohttp itself comes with a Websocket coroutine client. When ichrome was first created, there were few options with such matching functions.

During the recent period, I first implemented a morebuiltins library to replace various functions in torequests.utils, and then the next step was to start httpx to replace the http and websocket parts of aiohttp.

I was busy at work and could only write code a little bit in my spare time. If you are looking forward to a more professional library, you can consider the Playwright series of Microsoft Team. One of the reasons for the creation of ichrome was that there were no options at the time, so it was developed on a temporary basis. Relatively speaking, the test coverage is not as good as most other libraries currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants