Sign error in downwelling radiation?

[glwagner]

These should be + not -:

ClimaOcean.jl/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl

Line 447 in 8a880b5

return @inbounds - (1 - α) * Qs - ϵ * Qℓ

Otherwise it implies that these fluxes have the opposite sign as the turbulent heat fluxes, eg

ClimaOcean.jl/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl

Line 392 in 8a880b5

ΣQ = Qd + Qu + Qc + Qv

and it is also inconsistent with the upwelling radiation

ClimaOcean.jl/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl

Lines 454 to 455 in 8a880b5

	# Note: positive implies _upward_ heat flux, and therefore cooling.
	return ϵ * σ * Tₒ^4

[glwagner]

I guess the problem is that the JRA55 data also has a sign inconsistent with Oceananigans convention:

julia> Qswt = ClimaOcean.JRA55.JRA55_field_time_series(:downwelling_shortwave_radiation; time_indices=:)
640×320×1×2920 FieldTimeSeries{InMemory} located at (Center, Center, ⋅) on CPU
├── grid: 640×320×1 LatitudeLongitudeGrid{Float32, Periodic, Bounded, Flat} on CPU with 3×3×0 halo and with precomputed metrics
├── indices: (:, :, :)
├── time_indexing: Cyclical(period=3.1536e7)
├── backend: InMemory()
└── data: 646×326×1×2920 OffsetArray(::Array{Float32, 4}, -2:643, -2:323, 1:1, 1:2920) with eltype Float32 with indices -2:643×-2:323×1:1×1:2920
    └── max=1581.63, min=0.0, mean=157.422

To fix this we need to reverse the sign in the JRA55 data when it is loaded.

I think we should always use the same sign convention to avoid confusion. This came up when trying to set up an idealized atmospheric state.

[navidcy]

Good catch!

[simone-silvestri]

might this be connected with #248?

[glwagner]

Ah no, there are two "sign errors" that cancel out. First the fluxes are loaded with the wrong sign (by our convention). But then there is this second sign error that cancels it out. So the solar insolation is heating like it should be I think. But it could easily produce a bug in the future so i think its important to fix this