Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root division by zero edge case #53

Open
haakon-e opened this issue Dec 18, 2024 · 0 comments · May be fixed by #56
Open

Root division by zero edge case #53

haakon-e opened this issue Dec 18, 2024 · 0 comments · May be fixed by #56

Comments

@haakon-e
Copy link
Member

For certain functions, you might find that two (proposed) roots give the same error, then you will get NaNs from this line:

RootSolvers.jl/src/RootSolvers.jl

Line 343 in 865530f

x1 -= y1 * Δx / Δy

(also present in the other solver options)

Will try to find time to check for this and break (i.e. converged)
@haakon-e haakon-e linked a pull request Dec 19, 2024 that will close this issue
Catch division by zero in SecantMethod #56
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch division by zero in SecantMethod CliMA/RootSolvers.jl
1 participant
@haakon-e