Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for integer order_column with not-null constraint #252

Open
nruth opened this issue Feb 19, 2017 · 4 comments
Open

support for integer order_column with not-null constraint #252

nruth opened this issue Feb 19, 2017 · 4 comments

Comments

@nruth
Copy link

nruth commented Feb 19, 2017

Currently I'm getting null values inserted, then I assume updated afterwards, which gets rejected by postgres if there is a not null constraint.

On removing the not-null constraint, I see created records being given positions (order_column) correctly, but I'd prefer not to remove the constraint.

Is there a way to improve this, or could it be documented that it's not supported & perhaps suggest something else like a deferred trigger and transactions in place of a not-null constraint?

@mceachen
Copy link
Collaborator

mceachen commented Mar 2, 2017

It seems absolutely reasonable for this to be supported.

Would you be willing to work on a PR? I'd be happy to review it.

@nruth
Copy link
Author

nruth commented Mar 2, 2017 via email

@nruth
Copy link
Author

nruth commented Mar 10, 2017

Quick update: I've asked a colleague to work on this. I'm aiming to review and send a PR within the next few weeks.

@smoyte
Copy link
Contributor

smoyte commented May 29, 2018

Any updates here? I too would like to have this. Could contribute work if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants