Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_load_textdomain_just_in_time for translations #465

Open
kushh23 opened this issue Dec 22, 2024 · 2 comments
Open

_load_textdomain_just_in_time for translations #465

kushh23 opened this issue Dec 22, 2024 · 2 comments
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@kushh23
Copy link

kushh23 commented Dec 22, 2024

Description

Similar to Codeinwp/neve#4322 and https://github.com/Codeinwp/sparks-for-woocommerce/issues/316

The issue occurs with Lightstart as well.

Step-by-step reproduction instructions

  1. Use WordPress 6.7 or 6.7.1
  2. Set site language to something other than en_US
  3. Ensure all translations are installed
  4. Refresh site

Screenshots, screen recording, code snippet or Help Scout ticket

It was reported here - https://wordpress.org/support/topic/translation-loading-triggered-too-early-help-with-_load_textdomain_just_in_tim/

Environment info

No response

Is the issue you are reporting a regression

No

@kushh23 kushh23 added the bug This label could be used to identify issues that are caused by a defect in the product. label Dec 22, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Dec 22, 2024
@girishpanchal30
Copy link
Contributor

@kushh23 @vytisbulkevicius I've reviewed this issue and fixed it here - #466

@kushh23
Copy link
Author

kushh23 commented Dec 23, 2024

@girishpanchal30 tested and the issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

No branches or pull requests

3 participants