Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tracked flips have the uId "1" #83

Closed
matthias-luger opened this issue Sep 21, 2024 · 2 comments
Closed

Multiple tracked flips have the uId "1" #83

matthias-luger opened this issue Sep 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@matthias-luger
Copy link
Collaborator

Multiple tracked flips in one response have the uId "1". Is this expected? I currently use it as a key for react to identify them, which causes re-rendering issues.
grafik

@matthias-luger matthias-luger added the bug Something isn't working label Sep 21, 2024
@Ekwav
Copy link
Member

Ekwav commented Sep 21, 2024

Thats the case for flips that were not listed on ah (also soldAuction all 0) the uid is a short version of the soldAuction currently.
You would want to identify tracked flips by their sellTime, you can optionally add the uid in case two items sell in the same second (unlikely but possible)

Generally using the time would also make it easier to find the flip again as they are ordered by time anyways.

@matthias-luger
Copy link
Collaborator Author

fixed by Coflnet/hypixel-react#1313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants