Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement warning by user ID. #6445

Closed
SeraphimRP opened this issue Sep 2, 2024 · 4 comments · Fixed by #6481
Closed

Implement warning by user ID. #6445

SeraphimRP opened this issue Sep 2, 2024 · 4 comments · Fixed by #6481
Labels
Category: Cogs - Warnings This is related to the Warnings cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.

Comments

@SeraphimRP
Copy link

What component of Red (cog, command, API) would you like to see improvements on?

warnings

Describe the enhancement you're suggesting.

It seems that this was once behavior for the cog a long while ago, but I would like to propose allowing warns by user ID. It would be useful to warn IDs of users who, say, violated a rule but left before any warning could be given.

Anything else?

I'm not sure how this would intersect with warn actions, I'm not sure how the cog would perform these on absent users. I would also be willing to try and take this enhancement on if that would be preferable. My current line of thought would be to replicate the member param validation from [p]warnings and ignore DMing if the member isn't present.

@SeraphimRP SeraphimRP added the Type: Enhancement Something meant to enhance existing Red features. label Sep 2, 2024
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Sep 2, 2024
@Needless2Say
Copy link

Hi, can I take this?

@aikaterna
Copy link
Member

We don't assign non-members to issues. Feel free to work on it if you wish.

@Flame442
Copy link
Member

At least as far back as the start of V3, warnings has always taken a Member as the argument (ref). Perhaps you are thinking of [p]ban or similar commands?

As you pointed out, this seems a little hard to address given the nature of a warnings based cog. warnings allows actions to run any arbitrary command on the user, and cannot guarantee that the command will succeed if given an ID of a user who has left the server. It would make sense to allow a [p]warn that would give enough points to execute the [p]ban command to be used on a user who has left the server, since a user who is at that tier should be banned regardless of if they try to rejoin the server, and the ban command is able to accept IDs of members not in the server. However, something like [p]timeout which requires the user to be in the server would need to wait for them to rejoin (resulting in the timeout length not starting until after they rejoined, for better or for worse). There is no easy way for warnings to tell the difference between these cases and handle them individually. The only option that could work is always waiting until the user rejoins, but that requires the bot to be online when the user joins for them to be punished.

I am not certain if that added complexity is worth the effort for this edge case. If a disruptive user is leaving before a moderator is able to take action, it may often make sense to consider them a troll and bypass the server's standard warnings track.

@Flame442 Flame442 added Status: Needs Discussion Needs more discussion. Category: Cogs - Warnings This is related to the Warnings cog. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Nov 24, 2024
@Ascensionn
Copy link
Contributor

I am not certain if that added complexity is worth the effort for this edge case. If a disruptive user is leaving before a moderator is able to take action, it may often make sense to consider them a troll and bypass the server's standard warnings track.

So yes, so in that case I can modify the [p]warn command to ban the user by their ID if they have already left the server. I also believe it is fair to assume they are a troll and should not be allowed back in the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Warnings This is related to the Warnings cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants