Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeper Style UI: Run in dialog not sidebar #10998

Open
1 task
pedropintosilva opened this issue Jan 23, 2025 · 0 comments
Open
1 task

Deeper Style UI: Run in dialog not sidebar #10998

pedropintosilva opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
bug Something isn't working unconfirmed

Comments

@pedropintosilva
Copy link
Contributor

pedropintosilva commented Jan 23, 2025

We now have Styles sidebar enabled and accessible via Format tab > Style list. It would be good if that wouldn't trigger a sidebar but instead a Style list Nonmodal dialog.

Sub tasks:

I have posted first about this in #10633 (review) . I have pasted its contents bellow:


Cool! I have playing with it already for some time (before the PR was made) well done :)

I think we briefly discuss this but let me try to emphasize here that I would strongly recommend to avoid new sidebars.

I would rather see: a "see all/expand" sort of a button added to the Home > Styles preview component; And a big button with a label added to the Format tab that would trigger the same Nonmodal dialog that can be moved around and close (not a sidebar)

Here is a draft look and feel (using existing button images, but of course we would use better ones)

image

Here ^ I have added:

  • Scroll button to go up
  • Scroll button to go down
  • The third button would open the new styles Nonmodal dialog (which all the styles as a list) . Here I use the same "more button" icon that we are already using elsewhere to signify "open dialog with more stuff"
    • This seems also to be the more familiar user pattern that users are used from MSO

Web dev tools changes:

CSS excerpt (click to expand)
#stylesview {
  border-top-right-radius: 0;
  border-bottom-right-radius: 0;
}

#stylesview-btn {
  border: 1px solid var(--color-stylesview-border);
  border-top-right-radius: var(--border-radius);
  border-bottom-right-radius: var(--border-radius);
  height: 64px;
  margin-left: -5px;
}
#stylesview-btn .vertical {
  gap: 0;
}
#stylesview-btn button img {
  width: var(--btn-img-size-m) !important;
  height: var(--btn-img-size-m) !important;

  box-sizing: border-box;
}

#stylesview-btn button {
width: var(--btn-size-s) !important;
height: var(--btn-size-s) !important;
}

New #stylesview-btn added after #stylesview:

HTML excerpt (click to expand)
<div id="stylesview-btn" class="notebookbar" style="gap: 0;"><div id="" class="notebookbar vertical"><div class="unotoolbutton notebookbar ui-content unospan-home-brush unoFormatPaintbrush no-label" tabindex="-1" id="home-brush" data-cooltip="Clone Formatting"><button class="ui-content unobutton" id="home-brush-button" aria-label="Clone Formatting"><img class="" alt="Clone Formatting" src="http://localhost:9980/browser/48c008a2e9/images/lc_scrolltoprevious.svg"></button></div><div class="unotoolbutton notebookbar ui-content unospan-home-brush unoFormatPaintbrush no-label" tabindex="-1" id="home-brush" data-cooltip="Clone Formatting"><button class="ui-content unobutton" id="home-brush-button" aria-label="Clone Formatting"><img class="" alt="Clone Formatting" src="http://localhost:9980/browser/48c008a2e9/images/lc_scrolltonext.svg"></button></div><div class="unotoolbutton notebookbar ui-content unospan-home-brush unoFormatPaintbrush no-label" tabindex="-1" id="home-brush" data-cooltip="Clone Formatting"><button class="ui-content unobutton" id="home-brush-button" aria-label="Clone Formatting"><img class="" alt="Clone Formatting" src="http://localhost:9980/browser/48c008a2e9/images/lc_morebutton.svg"></button></div></div></div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed
Projects
Status: No status
Development

No branches or pull requests

2 participants