Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[♻Housekeeping] Improve our NuGet package quality #92

Closed
pictos opened this issue Jul 25, 2022 · 5 comments
Closed

[♻Housekeeping] Improve our NuGet package quality #92

pictos opened this issue Jul 25, 2022 · 5 comments
Labels
♻ housekeeping Related to internal changes not affecting the published libraries

Comments

@pictos
Copy link
Member

pictos commented Jul 25, 2022

Today our NuGet package isn't great and after watching this amazing talk from Claire I saw that we can make our package even better!
Helping users to see our code from VS, and debug our code which will help us fix bugs (since the users can provide more complete information), we can prevent breaking changes, etc...

I'll open one PR per item, to make it easy to review it and see if our CI will be happy.

[ ] Add Source-Link
[ ] Turn-on package validation
@pictos pictos added the ♻ housekeeping Related to internal changes not affecting the published libraries label Jul 25, 2022
@pictos pictos mentioned this issue Jul 25, 2022
Closed
6 tasks
@TheCodeTraveler TheCodeTraveler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
@TheCodeTraveler
Copy link
Collaborator

image

https://github.com/dotnet/sourcelink

@pictos
Copy link
Member Author

pictos commented Nov 17, 2023

@brminnick should we remove the package added by the #93?

@TheCodeTraveler
Copy link
Collaborator

No worries! #93 was never merged ✅

@pictos
Copy link
Member Author

pictos commented Nov 17, 2023 •
edited
Loading

Oh, I thought this was the MCT repo. We merged the package there

@TheCodeTraveler
Copy link
Collaborator

No worries there too! Vlad removed it in the .NET 8 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♻ housekeeping Related to internal changes not affecting the published libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheCodeTraveler @pictos