Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] qanti3_filter.py :: invalid Rscript detection #353

Open
1 of 2 tasks
EricDeveaud opened this issue Nov 19, 2024 · 0 comments
Open
1 of 2 tasks

[BUG] qanti3_filter.py :: invalid Rscript detection #353

EricDeveaud opened this issue Nov 19, 2024 · 0 comments
Labels
triage For developers to check

Comments

@EricDeveaud
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you loaded the SQANTI3.env conda environment?

  • I have loaded the SQANTI3.env conda environment

Problem description

while testing SQANTI3 (commit aaeb907)

installation was done manualy, no conda I noticed that sqanti3_filter.py have an incorect Rscript check.
see:

build :SQANTI3/SQANTI3-5.2.2 > sqanti3_filter.py --help
/opt/gensoft/exe/SQANTI3/5.2.2/bin/sqanti3_filter.py:33: DeprecationWarning: Use shutil.which instead of find_executable
  RSCRIPTPATH = distutils.spawn.find_executable('Rscript')
Traceback (most recent call last):
  File "/opt/gensoft/exe/SQANTI3/5.2.2/bin/sqanti3_filter.py", line 39, in <module>
    if os.system(RSCRIPTPATH + " --version")!=0:
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

this is due to RSCRIPTPATH = distutils.spawn.find_executable('Rscript') returning None used in os.sytem

It seems more logical to have something like that

RSCRIPTPATH = distutils.spawn.find_executable('Rscript')
if RSCRIPTPATH is None:
    print("Rscript executable not found! Abort!", file=sys.stderr)
    sys.exit(-1)

regards

Eric

Code sample

No response

Error

No response

Anything else?

No response

@EricDeveaud EricDeveaud added the triage For developers to check label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage For developers to check
Projects
None yet
Development

No branches or pull requests

1 participant