-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMTRIAGE-7509: Create workaround for USS-1.1 customers #5667
base: release/1.6
Are you sure you want to change the base?
Conversation
|
||
**Note:** use above $USERNAME and $PSWD for VCS login | ||
|
||
Step-4: Apply fix against import_branch found in Step-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add back-quotes around import_branch
to make it stand out.
Add new role to enable `iscsid` and `multipathd` service: | ||
|
||
```bash | ||
ncn-m001:~/csm-config-management # cat roles/csm.enable_iscsid_multipathd/tasks/main.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn this into a script they can cut-n-paste. Make this first line:
cat > roles/csm.enable_iscsid_multipathd/tasks/main.yml << EOF
name: multipathd | ||
state: started | ||
enabled: true | ||
ncn-m001:~/csm-config-management # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then change this line to just
EOF
ncn-m001:~/csm-config-management # | ||
``` | ||
|
||
Apply below changes to “csm-config-management/csm_packages.yml” to Application-nodes only play and Compute-nodes only play under “csm_services” in order to enable `iscsid` and `multipathd` services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to: "Apply the following changes"
Also use back-tics, not double quotes, for csm-config-management/csm_packages.yml
+ - role: csm.enable_iscsid_multipathd | ||
``` | ||
|
||
Step-5: Commit above changes and push the changes to VCS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to "Commit the changes and push them to VCS"
ncn-m001:/home/csm-config-management # cray cfs configurations describe $CFS_CONFIG --format json | jq '. | del(.lastUpdated) | del(.name)' > $CFS_CONFIG | ||
``` | ||
|
||
Step-7: Update commit id ($COMMIT from step 5 in $CFS_CONFIG for “csm_packages.yml”) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put both $COMMIT
and $CFS_CONFIG
in back-ticks, and change to back-tics for csm_packages.yml
.
ncn-m001:/home/csm-config-management # git commit -m "fix for CASMTRIAGE-7509" | ||
ncn-m001:/home/csm-config-management # git push --set-upstream origin CASMTRIAGE-7509 | ||
|
||
ncn-m001:/home/csm-config-management # COMMIT=`git log | head -n 1 | awk '{print $2}'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A simpler command is:
COMMIT=$(git log -1 --pretty='format:%H')
|
||
Step-9: Create new BOS session template with this new config change | ||
|
||
Please refer: [Create BOS session template for iSCSI SBPS](../boot_orchestration/Create_a_Session_Template_to_Boot_Compute_Nodes_with_SBPS.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to: Please refer to:
|
||
## Workaround Description | ||
|
||
Step-1: Get the version of the “csm-packages” from compute node BOS session template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the "Step-n" need more prominence.
Option 1: Make this a heading by adding ###
to the beginning of each of the lines.
Option 2: Make it bold with **Step-1**
,
Then, everywhere where a reference is made to one of the steps, make it bold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this looks good. Most of my comments are to improve readability, and are not about the contents.
Markdown linkcheck, spellcheck, and stylecheck need to be fixed before merging. |
- WAR doc for enabling iscsid and multipathd services to support iSCSI SBPS for USS-1.1 customers.
3730bf4
to
1728569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this PR, but I do recommend we take the suggestions from Nathan and Lindsay to improve readability slightly.
Signed-off-by: ravikanth-nalla-hpe <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prompts need to be pulled out of the copy-pasteable code snippets along with the command output, in doing so the copy-paste buttons will work appropriately in the rendered docs.
The prompts, if important, can be included in the text preceding the code snippet as described here.
```text | ||
nid000004:~ # dmesg -T | grep "SQUASHFS error" | head -n 1 | ||
[Sat Nov 2 22:32:41 2024] SQUASHFS error: xz decompression failed, data probably corrupt | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```text | |
nid000004:~ # dmesg -T | grep "SQUASHFS error" | head -n 1 | |
[Sat Nov 2 22:32:41 2024] SQUASHFS error: xz decompression failed, data probably corrupt | |
``` | |
```bash | |
dmesg -T | grep "SQUASHFS error" | head -n 1 | |
``` | |
Example output: | |
``` | |
[Sat Nov 2 22:32:41 2024] SQUASHFS error: xz decompression failed, data probably corrupt | |
``` | |
Description
CASMTRIAGE-7509: Create workaround for USS-1.1 customers
iSCSI based boot content projection which is also known as "Scalable Boot Content Projection" (SBPS) for rootfs and PE images is supported in version CSM 1.6.0 and above. On a customer system, using CSM-1.6.0 with USS-1.1.x on compute nodes/ UANs in order to support AARCH64 images, iscsid and multipathd services are not enabled by default. SBPS fails if these services are not enabled by default on compute/ UANs.
Checklist
.github/CODEOWNERS
with the corresponding team in Cray-HPE.