Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casmcms 8164 #5722

Open
wants to merge 1 commit into
base: release/1.6
Choose a base branch
from
Open

Casmcms 8164 #5722

wants to merge 1 commit into from
+1 −1

Conversation

jsollom-hpe
Copy link
Contributor

Description

Improved the BOS Documentation

Checklist

  • If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
  • If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
  • My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

@jsollom-hpe jsollom-hpe requested review from a team as code owners February 4, 2025 13:54
mharding-hpe
mharding-hpe requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mharding-hpe mharding-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR was accidentally made against the wrong branch, given the large number of commits in it that were not authored by Jason and are not BOS-related.

@jsollom-hpe jsollom-hpe changed the base branch from release/1.7 to release/1.6 February 4, 2025 19:09
@jsollom-hpe jsollom-hpe changed the title Casmcms 8164 WIP: Casmcms 8164 Feb 4, 2025
@jsollom-hpe
Copy link
Contributor Author

I think this PR was accidentally made against the wrong branch, given the large number of commits in it that were not authored by Jason and are not BOS-related.

Correct. I meant this to be against CSM-1.6.

@mharding-hpe mharding-hpe self-requested a review February 4, 2025 19:56
mharding-hpe
mharding-hpe approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@mharding-hpe mharding-hpe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This should also be "back"ported to release/1.7, I think.

@jsollom-hpe @mharding-hpe
CASMCMS-8164: Better describe limitations around etag
4bc7853 
Better describe etags in the BOS session template.
@jsollom-hpe jsollom-hpe changed the title WIP: Casmcms 8164 Casmcms 8164 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharding-hpe mharding-hpe mharding-hpe approved these changes

@jsl-hpe jsl-hpe Awaiting requested review from jsl-hpe

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsollom-hpe @mharding-hpe