Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gl-light.js:gLColor #3

Open
Cryptix720 opened this issue Sep 12, 2018 · 0 comments
Open

Refactor gl-light.js:gLColor #3

Cryptix720 opened this issue Sep 12, 2018 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right

Comments

@Cryptix720
Copy link
Owner

I've selected gl-light.js:gLColor for refactoring, which is a unit of 26 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Limit the length of code units to 15 lines of code.
  • Why
    Small units are easier to analyse, test and reuse.
  • How 🔧
    When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@Cryptix720 Cryptix720 added help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right labels Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant